On Sun, Nov 15, 2020 at 6:42 PM Johannes Sixt <j6t@xxxxxxxx> wrote: > > Am 15.11.20 um 21:12 schrieb Matheus Tavares Bernardino: > > Thank you both for the comments. I'll try to send v2 soon. > > > > On Fri, Nov 13, 2020 at 10:47 AM Derrick Stolee <stolee@xxxxxxxxx> wrote: > >> > >> On 11/12/2020 6:54 PM, Elijah Newren wrote: > >>> > >>> Do we also want to include a testcase where the user specifies a > >>> directory and part of that directory is within the sparsity paths and > >>> part is out? E.g. 'git sparse-checkout set /sub/dir && git rm -r > >>> sub' ? > >> > >> That is definitely an interesting case. > > > > I've added the test [1], but it's failing on Windows and I'm not quite > > sure why. The trash dir artifact shows that `git sparse-checkout set > > /sub/dir` produced the following path on the sparse-checkout file: > > "D:/a/git/git/git-sdk-64-minimal/sub/dir". > > If 'git sparse-checkout' is run from a bash command line, I would not be > surprised if the absolute path is munched in the way that you observe, > provided that D:/a/git/git/git-sdk-64-minimal is where your MinGW > subsystem is located. I that the case? Yeah, that must be it, thanks. I didn't run the command myself as I'm not on Windows, but D:/a/git/git/git-sdk-64-minimal must be the path where MinGW was installed by our GitHub Actions script, then. I'll use "sub/dir" without the root slash in t3600 to avoid the conversion. Thanks again!
