On 13.11.2020 06:06, Jeff King wrote: > I recently ran into a case where Git could not read the pack it had > produced via running "git repack". The culprit turned out to be an .idx > file which crossed the 4GB barrier (in bytes, not number of objects). > This series fixes the problems I saw, along with similar ones I couldn't > trigger in practice, and protects the .idx loading code against integer > overflows that would fool the size checks. Would it be feasible to have a test case for this large index case? This should very certainly have an EXPENSIVE tag, or might even not yet work on windows. But hopefully someday I'll find some more time to push large object support on windows forward, and these kind of tests would really help then.
