On 11/10/20 5:23 PM, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > >> This patch lets callers write: >> >> git rev-parse --end-of-options "$rev" -- "$path" >> >> and: >> >> git rev-parse --verify --end-of-options "$rev" >> >> which will both treat "$rev" always as a revision parameter. > > Nice. The only iffy case I can think of is that we can never have > "--" to specify a rev, because with "git cmd -- -- path" we don't > know which double-dash among the two is the disambiguator that makes > the other double-dash to be either rev or path, but that is not a > new problem with this change. I think Git should at least reject refs named "--", since they cause problems in so many places. Sincerely, Demi
Attachment:
OpenPGP_0xB288B55FFF9C22C1.asc
Description: application/pgp-keys
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
