Hi Felipe, On Mon, Nov 09, 2020 at 03:52:48PM -0600, Felipe Contreras wrote: > It is possible to have a recursive aliases like: I am not an expert or user of the Bash completion scripts in contrib, so I'll refrain from reviewing that portion of the patch. I would, however, recommend that you avoid the word 'recursive' here. Git rightly detects and rejects recursive and looping aliases. In fact, the example that you give below: > l = log --oneline > lg = l --graph Is not even recursive. I would instead recommend calling 'lg' a "nested" alias. You could argue about whether it is "l", "lg", or both that are nested, but I think renaming the patch to "completion: bash: support nested aliases" and then a s/recursive/nested throughout the patch message would be sufficient. > So the completion should detect such aliases as well. Thanks, Taylor
