On 2020-11-04 at 23:01:57, Emily Shaffer wrote: > Hiya, we took a look in the review club, but I'll try to keep it simple. > > On Fri, Oct 09, 2020 at 07:15:09PM +0000, brian m. carlson wrote: > > > > There are a bunch of different situations in which one would like to > > have an absolute and canonical or a relative path from Git. > > I think specifically you are interested in this situation: > https://github.com/git-lfs/git-lfs/issues/4012 Yes, that's the case I'm interested in. > I think this would have been useful to see in the cover letter :) There > was a lot of "but why" during the review club meeting. Sorry about that. When I'm sending patches to Git that benefit Git LFS, I want to be careful to build features that are generally applicable and don't just try to shove in features that benefit the project I maintain, so I'm often a little hesitant to mention my particular use case and try to let the patch stand on its own. I know that there are several competing projects in this space, and I want to be sensitive to not privileging my own just because I'm a frequent contributor. I'll try to strike a better balance here in the future. > Also, there was some brief wondering: if this option is useful in 'git > rev-parse', would it be useful in other commands too? I thought maybe it > would be more useful as an arg to 'git' itself, but on inspection, not > really - because you wouldn't be able to switch the format in the middle > of a bunch of args, like you can now. The way it's written here, > though, should mean a smooth transition to something like OPT__VERBOSE > or OPT__QUIET if we discover lots of folks would find use. Yeah, I think this could be a thing we add in the future, but I'm generally comfortable with this being just in rev-parse, since that's the command that folks tend to use when scripting, but we'll see if other folks think differently. -- brian m. carlson (he/him or they/them) Houston, Texas, US
Attachment:
signature.asc
Description: PGP signature
