On Tue, Aug 14, 2007 at 03:08:52PM +0100, Johannes Schindelin wrote: > Shouldn't read_cache() be _only_ called if > > - it has not been read yet, and > - .gitattributes was not found in the work tree? > > IOW check-attr is the wrong place for your patch IMHO. I admit I just cargo-culted what builtin-checkout-index did upon starting. Off the cuff, though, I don't see how the cache could ever already be loaded upon the start of cmd_check_attr, and the way the attr.c code is written, the cache be loaded when we check attributes or it will default to the old behavior (only checking the working directory.) What would you suggest here? -bcd - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
