On Wed, Nov 04, 2020 at 12:01:53PM -0500, Eric Sunshine wrote:
> > diff --git a/builtin/log.c b/builtin/log.c
> > @@ -1942,20 +1942,20 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
> > + if (use_stdout + !!output_directory > 1)
> > + die(_("specify only one of --stdout, --output, and --output-directory"));
>
> Is mention of --output intentional here? The commit message only talks
> about --stdout and --output-directory.
Whoops, thanks. I wrote this line after adding the new feature, but
forgot to revise it when I rebased.
> It's subjective, but "mutually exclusive" sounds a bit more consistent
> with other similar error messages elsewhere:
>
> --stdout, --output, and --output-directory are mutually exclusive
Yeah, that reads better. I remember I reworded it a few times to try to
get it not-awkward, but I'm not sure how I failed to come up with that
quite obvious wording. ;)
-Peff
