Jeff King <peff@xxxxxxxx> writes: > On Tue, Nov 03, 2020 at 12:21:42PM -0800, Junio C Hamano wrote: > >> >> So something like this won't harm VS Code more than we currently do, >> >> while telling users what is wrong with their command line? >> > >> > Yeah, I was wondering if we'd want the patch you sent, or if we should >> > turn those die() calls into warning() and disable the flags up front. >> [...] >> >> diff --git c/builtin/log.c w/builtin/log.c > > Since we now have identified the caller that was passing in the bogus > options, and it has already been fixed, I'm inclined to say we should go > with your die() patch from earlier (modulo the pathspec.nr fixup) and > call it done. > > Do you want to roll that up with a commit message? OK, will try.
