Josh Steadmon <steadmon@xxxxxxxxxx> writes: > When trace2 is enabled and trace2.advertiseSID is true, advertise > upload-pack's trace2 session ID via the new trace2-sid capability. I would have imagined when advertiseSID is enabled, trace2, at least the part that allocates and assigns the session ID, ought to be enabled automatically. But the above goes in a different direction and requires both to be enabled. Any compelling reason behind the choice? Does the documentation added by this series make it clear that asking for advertiseSID does NOT automatically enable allocation of session IDs (even if it does not explain why it does not happen)? Thanks.