On Fri, Oct 30, 2020 at 09:03:38AM -0700, Elijah Newren wrote: > > It would be nice if we had some actual perf numbers to report here, so > > we could know exactly how much it was buying us. But I guess things are > > a bit out-of-order there. You want to do this series first and then > > build merge-ort on top as a user. We could introduce the basic data > > structure first, then merge-ort, and then start applying optimizations > > with real-world measurements. But I'm not sure it's worth the amount of > > time you'd have to spend to reorganize in that way. > > Yeah, the perf benefits didn't really come until I added a > strmap_clear() based on this, so as you discovered I put perf numbers > in patch 7 of this series. Should I add a mention of the later commit > message at this point in the series? Nah, I think it's OK as it is. That kind of thing matters more for reviewing than when you find the commit later on. And we're already discussing it during the review. -Peff
