On Mon, Nov 02, 2020 at 09:35:54PM -0800, Jonathan Nieder wrote:
> I think you're saying that we don't need a "push" v2 because v0
> already has what a user would want.
>
> Git protocol v2 for fetch brought two major changes:
>
> - it changed the response for the initial request, allowing
> abbreviating the ref advertisement at last
>
> - it defined a structure for requests and responses, simplifying the
> addition of later protocol improvements. In particular, because the
> initial response is a capability advertisement, it allows changing
> the ref advertisement format more in the future.
>
> Both of those changes would be valuable for push. The ref
> advertisements are large, and matching the structure of commands used
> by fetchv2 would make debugging easier.
>
> There are some specific applications I'm interested in after that
> (e.g., pushing symrefs), but the fundamental extensibility improvement
> is larger than any particular application I could think of.
You pretty much summed up what I was going to respond. :)
But I'd go further here...
> That said, I'm not against experimenting with extra parameters before
> we go there, as a way of getting more information about what a
> workable negotiation for push looks like.
I'd prefer to avoid doing this as an extra parameter for a few reasons:
- once it's in a released version, it's much harder for us to take it
away
- the extra parameters area is a hack that helped us bootstrap v2. We
could probably use the same hack to bootstrap v3, etc. But it has
limitations for stuffing in arbitrary data. An obvious one is size.
We can transmit a single base, but would be limited if we wanted to
be able to send multiple. We already ran into this once with the
"symref=foo:bar" capability overflowing pkt-line limits. Here I'm
not even sure what the limits might be (it's subject to things like
how big an HTTP header a proxy will pass, or how large an
environment variable an ssh implementation supports)
- it potentially pushes more data/work outside of the git protocol
itself. E.g., web servers have to translate Git-Protocol headers
into the GIT_PROTOCOL environment for v2. I guess this new field
works in our tests because we copy the header's value entirely in
our apache.conf. But I wonder how many systems in the wild may only
work if it contains "version=2".
-Peff
