Re: [PATCH v2] upload-pack: allow stateless client EOF just prior to haves

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Duvall <dan@xxxxxxxxx> writes:

> On Fri, Oct 30, 2020 at 4:45 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>
>> >  t/t5705-upload-pack-stateless-shallow-eof.sh | 24 ++++++++++++++++++++
>> >  upload-pack.c                                | 13 ++++++++++-
>> >  2 files changed, 36 insertions(+), 1 deletion(-)
>> >  create mode 100755 t/t5705-upload-pack-stateless-shallow-eof.sh
>>
>> I'd rather see it folded in an existing test, if it makes sense.
>
> With v3 I've moved it into t/t5530-upload-pack-error.sh. That test
> file seemed to mostly contain errant cases, but I thought it might be
> close enough as this was previously an errant case. If there's a
> better place for it I'm happy to move it again.

5530 is good.  It is not too big or full of unrelated tests, and it
is about sanity in the low level protocol exchange.

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux