On Thu, Oct 29, 2020 at 9:51 PM Daniel Duvall <dan@xxxxxxxxx> wrote: > [...] > Instead, upload-pack should gently peek for an EOF between the sending > of shallow/unshallow lines (followed by flush) and the reading of client > haves. If the client has hung up at this point, exit normally. > > Signed-off-by: Daniel Duvall <dan@xxxxxxxxx> > --- > diff --git a/t/t9904-upload-pack-stateless-timely-eof.sh b/t/t9904-upload-pack-stateless-timely-eof.sh > @@ -0,0 +1,24 @@ > +#!/bin/sh > + > +test_description='stateless upload-pack gently handles EOF just after want/shallow/depth/flush' > + > +. ./test-lib.sh > + > +D=$(pwd) What is the purpose of this assignment? It doesn't seem to be used anywhere in this script. > +test_expect_success 'upload-pack outputs flush and exits ok' ' > + test_commit initial && > + head=$(git rev-parse HEAD) && > + hexsz=$(test_oid hexsz) && > + > + printf "%04xwant %s\n%04xshallow %s\n000ddeepen 1\n0000" \ > + $(($hexsz + 10)) $head $(($hexsz + 13)) $head >request && > + > + git upload-pack --stateless-rpc "$(pwd)" <request >actual && > + > + printf "0000" >expect && > + > + test_cmp expect actual > +' > + > +test_done
