Matheus Tavares <matheus.bernardino@xxxxxx> writes: > From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > > Create `enum conv_attrs_classification` to express the different ways > that attributes are handled for a blob during checkout. > > This will be used in a later commit when deciding whether to add a file > to the parallel or delayed queue during checkout. For now, we can also > use it in get_stream_filter_ca() to simplify the function (as the > classifying logic is the same). > > Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > [matheus.bernardino: use classification in get_stream_filter_ca()] > Signed-off-by: Matheus Tavares <matheus.bernardino@xxxxxx> > --- > convert.c | 26 +++++++++++++++++++------- > convert.h | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 52 insertions(+), 7 deletions(-) Yup, having an actual user of the new layer of abstraction in the same patch makes it more easily understandable. If only the new function and enum were presented without anybody using, it would have been much harder to swallow, without visible and immediate benefit. Looking good.
