The operation of discovering uninteresting commits (that is, all the
commits that immediately precede a patch but don't have any patch
among their ancestors) is expensive. Make it less so, by using the
fact that we're done as soon as we've seen all patch commits.
This is probably less of a win than might be naively expected, since
we give the --topo-order flag to git-rev-list, which causes it to have
to read the full DAG to even start producing the output; but at least
we skip quite a bit of looping and set manipulation in Python, which
ought to be worth _something_.
Signed-off-by: Karl Hasselström <kha@xxxxxxxxxxx>
---
stgit/stack.py | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/stgit/stack.py b/stgit/stack.py
index 1b6808e..d3756d0 100644
--- a/stgit/stack.py
+++ b/stgit/stack.py
@@ -472,11 +472,17 @@ class UninterestingCache:
for p in parents:
if not p in interesting:
uninteresting.add(p)
- continue
+
+ # If this is the last patch commit, there is no way we
+ # can encounter any more uninteresting commits.
+ patches.remove(commit)
+ if not patches:
+ break
# Commits with interesting parents are interesting.
- if interesting.intersection(parents):
+ elif interesting.intersection(parents):
interesting.add(commit)
+
self.__uninteresting = uninteresting
out.done()
def create_patch(self, name, top, bottom):
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
