Hi Dyrone, > Le 26 oct. 2020 à 23:12, Teng Long via GitGitGadget <gitgitgadget@xxxxxxxxx> a écrit : > > From: Dyrone Teng <dyroneteng@xxxxxxxxx> > > Partial clones are created using 'git clone', but there is no related > help information in the git-clone documentation during a period. Add > a relevant section to help users understand what partial clones are > and how they differ from normal clones. > > The section briefly introduces the applicable scenarios and some > precautions of partial clone. If users want to know more about its > technical design and other details, users can view the link of > git-partial-clone(7) according to the guidelines in the section. > > Signed-off-by: Teng Long <dyroneteng@xxxxxxxxx> > --- > clone: document partial clone section > > Partial clones are created using 'git clone', but there is no related > help information in the git-clone documentation during a period. Add a > relevant section to help users understand what partial clones are and > how they differ from normal clones. > > The section briefly introduces the applicable scenarios and some > precautions of partial clone. If users want to know more about its > technical design and other details, users can view the link of > git-partial-clone(7) according to the guidelines in the section. Since your series has just the one patch now, you don't need to add a description in your GitGitGadget (GGG) PR. That's why it appears two times here: the text above the '---' is the commit message, and the text below is the PR description. In the context of a one-patch series, you can use this space to add additional info that do not fit into the commit message, for example questions about your patch, etc. It is also a good idea (and viewed positively by reviewers) to use it to add a summary of what changed in your series since the last version you sent. I encourage you to read MyFirstContribution [1] for a good tutorial on the contribution process. Also, GGG understands that if you end your PR description with a line starting with "CC:" and an email address, further iterations of your series will be sent to those email addresses. So it would have been good to add Stolee in there, like this: CC: Derrick Stolee <stolee@xxxxxxxxx> (Junio prefers not to be directly CC'ed). > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-745%2Fdyrone%2Fmaster-v3 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-745/dyrone/master-v3 > Pull-Request: https://github.com/git/git/pull/745 > > Range-diff vs v2: > > 1: 6f340d9aad < -: ---------- partial-clone: set default filter with --partial > 2: 9baf4c8ba3 < -: ---------- clone: document --partial and --filter options > 3: c1a44a3509 ! 1: 681c5dcb79 clone: document partial clone section > @@ Commit message > clone: document partial clone section > > Partial clones are created using 'git clone', but there is no related > - help information in the git-clone documentation. Add a relevant section > - to help users understand what partial clones are and how they differ > - from normal clones. > + help information in the git-clone documentation during a period. Add > + a relevant section to help users understand what partial clones are > + and how they differ from normal clones. It appears that you sent the same version of the patch as in v1, instead of the one you sent in v2 ? You had removed "during a period" for v2, but here it pops up again. You should check that you've sent the more up to date version of your patch, before sending v4. I will not comment on the patch below, since it's not the more up-to-date. I will send comments shortly on the v2 version by replying to [2] (the v2 version of your patch). Cheers, Philippe. [1] https://git-scm.com/docs/MyFirstContribution [2] https://lore.kernel.org/git/c1a44a35095e7d681c312ecaa07c46e49f2fae67.1586791560.git.gitgitgadget@xxxxxxxxx/
