On Mon, Oct 26, 2020 at 10:12:45AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > By the way, I wondered why we needed to do this parsing at all. The > > patch below does this in a much simpler way. It's a little bit ugly, I > > think, because we have to call getenv() ourselves. But that's the way > > fmt_ident() has always worked. We could probably improve that now that > > it takes a whose_ident flag (before that, it had no idea if we wanted > > author or committer ident). > > > > This is on top of the fixes (but we'd perhaps just want to do those on > > 'maint' as the minimal fix). > > This could be the nicest step in the whole series, but let's leave > it out of the branch meant for 'maint'. I think that's sensible. Looks like you queued it separately already, so thank you. :) -Peff
