On Mon, Oct 26, 2020 at 10:18:18PM +0000, Philip Oakley wrote: > > +NOTES > > +----- > > + > > +Note that Git does not allow the `.gitmodules` file within a working > > +tree to be a symbolic link, and will refuse to check out such a tree > > +entry. This keeps behavior consistent when the file is accessed from the > > +index or a tree versus from the filesystem, and helps Git reliably > > +enforce security checks of the file contents. > > > > EXAMPLES > > -------- > The text looks good to me, with security point explicitly mentioned just > for .gitmodules file. > > However, is placing the Note so far down appropriate (.gitattributes and > .gitignore), given that there is within the descriptions a discussion of > the priority order for finding those files? Definitely a "NOTES" section should go in that spot, but possibly the text should be in the "DESCRIPTION" section. I was worried about cluttering that early part with a detail that most people wouldn't care too much about. Looks like my patch is in 'next'; do you want to propose a patch moving it around on top? -Peff
