Hi, On Fri, 23 Oct 2020, Jeff King wrote: > On Mon, Oct 19, 2020 at 07:35:39PM +0000, Johannes Schindelin via GitGitGadget wrote: > > > Changes since v1: > > > > * Instead of papering over the underlying cause, the patch was completely > > changed to actually fix the bug and add a proper regression test for it > > (originally, I wanted to act according to the common notion that good > > programmers are lazy, oh my, see how well that worked out for me). > > Thanks for fixing this. Your explanation looks thorough and the code > looks correct. Definitely patches 1 and 2 look good to me. I left a few > comments on patch 3. Thank you. After thinking about this for several days, I will drop patch 3/3 because it is unclear to me how to implement what you suggested without reverting the intention of Jonathan's patch that made `pkt-line` depend on `sideband` instead of the other way round. Ciao, Dscho
