On Wed, Jul 3, 2019 at 2:06 PM SZEDER Gábor <szeder.dev@xxxxxxxxx> wrote: > As for the latter part of the series, I think the more hard-coded > options we can get rid of the better we are off, and I would rather > not see them making a comeback. I don't really have an opinion about > patches 8 and 9 (that old wrapper is probably just bitrotting away, > but I just tried to source our bash completion script from Zsh, and > apart from the deprecation warning it appeared to work). I just added those patches to highlight the issue, which is very real, and you can see by running the added tests. I will maintain those patches separately in a branch named "hacks" in my project git-completion. If anybody wants the latest completion with an old version of Git they can use my project instead. https://github.com/felipec/git-completion/commits/hacks -- Felipe Contreras
