Taylor Blau <me@xxxxxxxxxxxx> writes: > Hi Nipunn, > > On Thu, Oct 22, 2020 at 12:21:04AM +0000, Nipunn Koorapati via GitGitGadget wrote: >> UPDATE SINCE v1 >> >> * Removed include of dir.h from fsmonitor.h as it's no longer needed > > This version all looks sensible to me. > > I'm still iffy on whether or not this series makes sense to apply > without the rest of the code that depends on it, but I'll leave that up > to Junio whether he wants to take the series as it is now, or wait for > other patches to come in on top. Sorry but I am not sure what you mean by "the code that depends on it". Are these two functions unused anywhere in the code? If so, the right way to clean them up may not be to turn them from inline to a proper definition, but to remove them ;-). If they have existing callers and it can be demonstrated that their callers do not benefit from them being inline, that by itself is a worthy clean-up, without adding any more callers, no? Confused... > In either case, these two patches are: > > Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx> > > Thanks, > Taylor
