On Thu, Oct 22, 2020 at 1:44 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > > There's still a space after the '<<' operator which should be removed: > > > > cat >expect <<EOF > > Also, this is outside any test_expect_*, which is unusual in > modernized test scripts. There are many other instances of > preparing expected output outside test_expect_* in this file, > so we may need another patch to clean them up. I noticed that, as well, but wasn't sure if mentioning it was worthwhile considering that this is a microproject and we're already at v5. It can certainly be addressed by someone as a follow-on patch if desired. > For now, within the context of this patch, let's just fix the space > after the << here-doc redirection operator, as you spotted. The > attached I'll squash into this patch. > > -cat >expect << EOF > +cat >expect <<EOF Looks fine.