Hi Eric,
>> +cleanup_crlf_refs () {
>> + for branch in ${LIB_CRLF_BRANCHES}; do
>
> Our style is to place 'do' on its own line:
>
> for branch in $LIB_CRLF_BRANCHES
> do
> ...
>
> This would be a syntax error if LIB_CRLF_BRANCHES is empty for some
> reason, but I suppose we don't really have to worry about it here(?).
Apparently, not in my shell, as I realized I had misspelled LIB_CRLF_BRANCHES as
LIB_CLRF_BRANCHES (CLRF instead of CRLF) at another place and the test was
passing correctly (the loop was not being entered at all though):
$ /bin/sh --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
$ for a in $b; do echo hello; done; echo $?
0
I've fixed that in v4 which I just sent.
Cheers,
Philippe.
