> I'm fine with both of these patches, but it may help to have a bit > more information about how they will be used. Presumably more patches > are coming that make use of the new public functions, but it'd be good > to know a little bit of why these changes are necessary. I believe the externs are just there to avoid pulling in `dir.h` from the include file - since it's only needed in the implementation. I believe at the time (12/2017) `dir.h` was not imported from `fsmonitor.h`, but it does appear imported now. I've eliminated the import of `dir.h` as it no longer appears necessary - which I will include in the next iteration of this diff. The test helper merely makes it easier to debug fsmonitor tests - will be useful to any developer working on fsmonitor related changes. I have an upcoming one related to fsmonitor in git checkout, which I've also revived, but I'm not 100% sure I'll get it through, but regardless, I believe this test-debugging change will be good. --Nipunn
