On Wed, Oct 21, 2020 at 02:24:22PM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > Any reason that these need to be externed explicitly? Note that these > > functions are already externed by default since you haven't said > > otherwise (and for no other reason than this'd be the only explicitly > > externed function in fsmonitor.h). > > Possibly due to the recent discussion? > > https://lore.kernel.org/git/xmqqtuv3ryhr.fsf_-_@xxxxxxxxxxxxxxxxxxxxxx/ Ah, thanks. I remember the thread, but I wasn't sure where the discussion ended up. After re-reading it, it sounds like new function declarations in header files should be prefixed with 'extern' (making this patch correct as it already is). Tangential to this discussion: are you still expecting a tree-wide change to start use extern everywhere? Thanks, Taylor
