Junio C Hamano <gitster@xxxxxxxxx> writes:
> Before dismissing the idea totally, let's see what potential use
> cases this change _could_ benefit, and see if there are already ways
> to satisfy these use cases without making this change. For example,
> if the user wants to examine the result before actually "committing"
> to move the target branch forward with this change, keeping it an
> option to back out if the result of cherry-picking turns out to be
> bad, the "--no-commit first, examine, and --continue or --abort"
> sequence may help such a workflow.
>
> But the user can already do so without this change:
>
> $ git checkout target_branch^0 ;#detach
> $ git cherry-pick source_branch
> ... examine the result ...
> ... and if it is satisfactory ...
> $ git checkout -B target_branch
> ... or if it is not, then discard ...
> $ git checkout target_branch
>
>> With this patch, we allow sequencer to save the metadata from the original
>> cherry-pick operation so that 'git cherry-pick --continue' can be called.
And if the user wants to do the inspection while on the target
branch, "commit -c/-C" is the perfect choice.
$ git cherry-pick --no-commit source_branch
... examine the result ...
... and if it is satisfactory ...
$ git commit -c source_branch
... or if it is not, then discard ...
$ git reset --hard
