Hey, > Again, it's a judgment call whether to go with modern style or follow > existing style of the file. > > Another option is to have a preparatory patch which first modernizes > the script, and then your new tests would follow modern style. But, > that may be outside of scope of your submission. > > To summarize: The only really actionable review comments are the minor > style nits in the C code. The nits about style issues in the tests are > judgement calls, and could be handled (by someone) at a later date. Thanks for the feedback, Eric. I would add the style nits in the upcoming patch. For the style issues in the tests maybe what I can do is I can submit another patch with this patch to modernize the test scripts of these files? I am expecting some feedback from the community on how to handle this.
