On Wed, Oct 21, 2020 at 02:41:39PM +0100, Phillip Wood wrote: > Hi Sangeeta > > It's great to see you tackling another patch > > On 21/10/2020 10:09, Sangeeta via GitGitGadget wrote: > > From: Sangeeta Jain <sangunb09@xxxxxxxxx> > > > > As `git rebase` was never prevented to run from subdirectory we shouldn't > > prevent `git bisect` to run from subdirectories. > > I'm not sure it's relevant to bisect whether or not rebase can be run from a > subdirectory. What is important is that we want all commands to be able to > be run from a subdirectory unless there is a good reason not to (and there > isn't for bisect) I'm not sure that that's the case: Junio pointed out a while[1] ago that we'd have to answer the question of "what happens if I'm in a subdirectory that goes away during some point of the bisection?". I think that you could probably find an answer to that question, but the fact that there isn't an obvious one seems to indicate that we're going down the wrong path. I agree that it would be nice to run bisect from any directory, but it may not be as easy as I'd hope. [1]: https://lore.kernel.org/git/xmqqpnd359l6.fsf@xxxxxxxxxxxxxxxxxxxxxx/ Thanks, Taylor
