Junio C Hamano <gitster@xxxxxxxxx> writes: > Charvi Mendiratta <charvi077@xxxxxxxxx> writes: > >> Modern practice is to avoid multiple commands per line, >> and instead place each command on its own line. >> >> Signed-off-by: Charvi Mendiratta <charvi077@xxxxxxxxx> >> --- > > This looks good, but I am wondering what happened between v3 and > v4. > > As you've demonstrated through the microproject that you can now > comfortably be involved in the review discussion, I am tempted to > suggest that we declare victory at this point and move on, but I > don't know what the plans are for the other 4 patches (I guess we > won't miss them that much---the micros are meant to be practice > targets). Actually I take it back. This does not look good as a standalone patch at all. It seems to depend on something in the 5-patch series. Please make sure that patches you send are usable by your recipients.
