On Tue, 20 Oct 2020 at 14:43, Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > > Hi Charvi > > On 19/10/2020 21:25, Taylor Blau wrote: > > Hi Charvi, > > > > On Mon, Oct 19, 2020 at 10:54:57PM +0530, Charvi Mendiratta wrote: > >> Yes, thanks a lot Philip I understood the reason. I will do the corrections in > >> commit message and commit body as below : > >> t7201: using 'git -C' to avoid subshell > >> > >> Using 'git-C' instead of 'cd' inside of subshell, to avoid the extra process > >> of starting a new subshell > >> > >> [...] > > > > That said, a couple of notes: > > > > - Your subject message is good. It is concise, to-the-point, and > > accurately describes the change. Good. > > > > - The body is similarly short, but could be rewritten to use the > > imperative mood. But, it is redundant with the subject. The subject > > says "we are using 'git -C' to avoid creating a subshell", and the > > patch says exactly the same. > > > > ...So, you can do one of two things. Either you can abbreviate the > > subject, adding the additional detail in the patch message, or you could > > leave the subject as-is and delete the patch message entirely. > > > > Either would be fine with me, but certainly Phillip or others could > > chime in, too. > > I'm happy with either, but I would suggest changing the subject so the > description starts with 'use' rather than 'using' > Thank you Phillip, I have updated the changes in the next patch . > Best Wishes > > Phillip > > > Thanks, > > Taylor > > Thanks and Regards, Charvi
