Michał Kępień <michal@xxxxxxx> writes: >> Cramming unrelated tests into a single one made me puzzled, staring >> at this line for longer than necessary before realizing that this is >> an attempt to catch a malformed regexp. If this were in a separate >> test with its own title, e.g. >> >> It would have been much easier to follow. > ... I will try > to come up with something more balanced in v4. We want to avoid going overboard and doing a full test matrix. But having it tested fully with one variant while testing just the basic for other variants may give us a good balance, e.g. "git log -p -I<regex>" is tested but we do not bother testing interactions with other options", while we try different combinations when testing "git diff --no-index -I<regex>", like multiple -I options etc. Thanks.
