On 16/10/2020 17:37, Junio C Hamano wrote:
Phillip Wood <phillip.wood123@xxxxxxxxx> writes:
... Reviewers that only read the patch without loading up the
test file in their editor have no indication that the test should be
clearing the config variable.
It is not a review if the code being updated is not checked for
sanity in its own context, is it?
It is disappointing that you have chosen to cut the original to those
few lines and reply just to them. The original message made the broader
point that having to check the previous tests in a file to figure out
what the state is at the beginning of any new test that gets added makes
life harder than it needs to be both for contributors and reviewers.
Phillip
