Re: --exit-code (and --quiet) broken in git-diff?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El 12/8/2007, a las 15:02, Steven Grimm escribió:

David Kastrup wrote:
I think I would call that a mistake. However, I don't see that fixing
it would actually be useful: if a pager gets called, this means that
git-diff might die with SIGPIPE (when the user quits the pager), and
that in turn has pretty much no meaning.  So one really needs to
redirect the output, anyway.


It does sort of make one wonder, though, if there's much point ever launching a pager when git-diff is run with --quiet -- it will never produce any output to page, so running a pager is guaranteed to always be a waste of cycles.

Yes, I thought the same thing when I read in the initial release notes (<http://www.kernel.org/pub/software/scm/git/docs/ RelNotes-1.5.1.txt>) that the "--quiet" option was explicitly "meant for scripted use", where naturally you don't want or need a pager... turns out I was writing a script, you see, and I wanted to test the commands out manually to be sure they did what I thought they would...

But as you say, refactoring this to bypass the pager when "--quiet" is passed may be unpleasantly complicated.

Cheers,
Wincent

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux