Re: [PATCH 0/5][Outreachy] modernizing the test scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 15, 2020 at 7:57 PM charvi-077 <charvi077@xxxxxxxxx> wrote:
>
> This is my first patch series to the GIT mailing list. I followed the
> link[1] and t7001 patches to modernize and clean up the test scripts.

Thanks for getting started contributing!

> This patch series :
>  -modernize the three test scripts : t7101, t7201 and t102.

s/t102/t7102/

On https://git.github.io/Outreachy-21-Microprojects/ we say:

"Find one test script that needs some of the same changes and make them."

So working only one test script, for example only t7101, would have
been better than working on 3 test scripts. Now that you started
working on 3 test scripts, it's ok to finish modernizing all these 3
test scripts though.

>  - cleans up with 5 types of changes in all the three scripts.
>    1. Converting the old old style test format to new one

s/old old/old/

>    2. Removing blankspaces in test bodies
>    3. Removing whitespaces after the redirect operator, according to
>       Codingguidelines .

s/Codingguidelines/CodingGuidelines/

>    4. Using git -C instead of cd
>    5. Placing all commands in seperate lines.

s/seperate/separate/

> Also, I have tested the scripts and set up travis CI[2].

Nice!

Thanks,
Christian.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux