Hey everyone, On Thu, Oct 15, 2020 at 8:15 PM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > diff --git a/submodule.c b/submodule.c > index 8f6227c993..c4182be633 100644 > --- a/submodule.c > +++ b/submodule.c > @@ -1679,6 +1679,8 @@ unsigned is_submodule_modified(const char *path, > int ignore_untracked) > strvec_pushl(&cp.args, "status", "--porcelain=2", NULL); > if (ignore_untracked) > strvec_push(&cp.args, "-uno"); > + else > + strvec_push (&cp.args, "--ignore-submodules=none"); > > prepare_submodule_repo_env(&cp.env_array); > cp.git_cmd = 1; > > fixes it, I'm unsure at the moment if we should be adding the extra flag > here or setting the appropriate option in status when -uno and > --ignore-submodules=<option> are both omitted though Ya, that does work and the PR passed all the tests after this correction. I have submitted the patch[1] for it and would be glad to have reviews on it from the git community. [1] https://public-inbox.org/git/pull.751.git.1602781723670.gitgitgadget@xxxxxxxxx/T/#u > > Have you setup a config.mak file? Mine looks like > > DEVELOPER = 1 > SANITIZE = address,leak > CFLAGS += -ggdb3 > CFLAGS += -fvar-tracking-assignments > CFLAGS += -fno-omit-frame-pointer > > Which will build git with warnings enabled, debugging information and > enables the address sanitizer. Then you can run the git you have built > under gdb with > > GIT_DEBUGGER=1 bin-wrappers/git > > If you want to debug a particular test then I find adding `test_pause` > to the test and then running > > GIT_DEBUGGER=1 git > > in the shell that the test opens (it sets up the path appropriately). > You may want to add LSAN_OPTIONS=detect_leaks=0 to the commands above or > set up a suppressions file > > I also use printf quite a bit but it does tend to break other tests > which can be awkward. > No, not yet. I would set it up. Thanks again! As my next step, I was looking for some #good-first-issue to work on where I found an issue[2]. Has someone already worked on it? If not, I would love to work on this. Or if you have anything else in mind that I could work on please do suggest to me. [2] https://github.com/gitgitgadget/git/issues/486[3] Thanks and Regards, Sangeeta
