Junio C Hamano <gitster@xxxxxxxxx> writes: > David Kastrup <dak@xxxxxxx> writes: > >> +test_expect_success 'Setting up post-commit hook' ' >> +mkdir -p .git/hooks && >> +cat <<EOF >.git/hooks/post-commit && >> +#!/bin/sh >> +touch $(pwd)/output >> +echo "Post commit hook was called." >> +EOF >> +chmod +x .git/hooks/post-commit' > > We have avoided to use here text inside test_expect_success, as > there have been reports that some otherwise reasonably usable > shells do not grok it. Ok. > Although I prefer to do everything, including the set-up part, > inside test_expect_success, please move this code outside. I can easily enough make it an echo. > Also I do not think you would want to say touch $(pwd)/output > there inside the here text that begins with <<EOF not <<\EOF. But I most certainly do! The same file should be touched regardless of what the cwd at the time of calling the hook is. Otherwise, I would not need the $(pwd) in the first place. The whole point is that it is expanded at the time of the hook creation. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
