Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > In run_git_commit() we do > > if (opts->gpg_sign) > strvec_pushf(&cmd.args, "-S%s", opts->gpg_sign); > else > strvec_push(&cmd.args, "--no-gpg-sign"); > > I'm not immediately clear why we pass --no-gpg-sign when > opts->gpg_sign isn't set ... Isn't it because there is a configuration that the &cmd may honor that forces gpg signing all the time? > but it makes me wonder if we should be doing > that here as well Possibly.
