On 10/8/2020 12:20 PM, Robert Karszniewicz wrote: > Changes default behaviour of `git log` and `git show` when no > command-line options are given. Doesn't affect behaviour otherwise (same > behaviour as with stash.showStat). > --- > I've wanted to have `show` and `log` show --stat by default, and I > couldn't find any better solution for it. And I've discovered that there > is stash.showStat, which is exactly what I want. So I wanted to bring > stash.showStat to `show` and `log`. I'm wondering: why should this be a config setting instead of just a configure alias? git config --global alias.logs "log --stat" My personal preference is to use "--graph --oneline" by default, so I use git config --global alias.lg "log --graph --oneline" and then type "git lg ..." whenever I'm looking at history. I also have an easy way to turn off the graph by using just "git log" when I want that disabled. > So far, setting log.showStat affects behaviour as described in the > commit message. > But it does so for `show` and `log` at the same time. I think they > should be configurable separately. (log.showStat and show.showStat) > > Before I do all the work, please tell me if this is the right approach > so far, and if the feature - when ready - would be accepted. (I'm aware > that documentation and tests are missing.) If this is something we want to do as a config instead of alias, I'm wondering if it is worth expanding the scope and thinking about these other arguments (like --graph, --oneline, etc.) and how they could be incorporated into a coherent config system. I worry that this initial step leads us down a road of slowly adding one-off config settings for each option when: 1. aliases exist, and 2. it becomes unclear which arguments have configured defaults. Thanks, -Stolee
