Re: [PATCH v2] userdiff: expand detected chunk headers for css

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Sohom Datta via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:

> From: Sohom <sohom.datta@xxxxxxxxxxxxxxxxxxx>

I'd call this line *1* for later reference...

> The regex used for the CSS builtin diff driver in git is only
> able to show chunk headers for lines that start with a number,
> a letter or an underscore.
>
> However, the regex fails to detect classes (starts with a .), ids
> (starts with a #), :root and attribute-value based selectors (for
> example [class*="col-"]), as well as @based block-level statements
> like @page,@keyframes and @media since all of them, start with a
> special character.
>
> Allow the selectors and block level statements to begin with these
> special characters.
>
> Signed-off-by: Sohom Datta <sohom.datta@xxxxxxxxxxxxxxxxxxx>
> ---

Looking good.

The "Name <email>" on line *1* must match that on the last
"signed-off-by" line, so I'll locally tweak the authorship information
before applying the patch.

Thanks.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux