On Thu, Oct 08, 2020 at 12:39:26AM -0700, Denton Liu wrote: > LIB_H := $(sort $(patsubst ./%,%,$(shell git ls-files '*.h' ':!t/' ':!Documentation/' 2>/dev/null || \ > $(FIND) . \ > @@ -998,9 +998,9 @@ LIB_OBJS += sigchain.o > LIB_OBJS += split-index.o > LIB_OBJS += stable-qsort.o > LIB_OBJS += strbuf.o > -LIB_OBJS += strvec.o > LIB_OBJS += streaming.o > LIB_OBJS += string-list.o > +LIB_OBJS += strvec.o > LIB_OBJS += sub-process.o > LIB_OBJS += submodule-config.o > LIB_OBJS += submodule.o > @@ -1066,15 +1066,15 @@ BUILTIN_OBJS += builtin/checkout-index.o > BUILTIN_OBJS += builtin/checkout.o > BUILTIN_OBJS += builtin/clean.o > BUILTIN_OBJS += builtin/clone.o > -BUILTIN_OBJS += builtin/credential-cache.o > -BUILTIN_OBJS += builtin/credential-cache--daemon.o > -BUILTIN_OBJS += builtin/credential-store.o > BUILTIN_OBJS += builtin/column.o > BUILTIN_OBJS += builtin/commit-graph.o > BUILTIN_OBJS += builtin/commit-tree.o > BUILTIN_OBJS += builtin/commit.o > BUILTIN_OBJS += builtin/config.o > BUILTIN_OBJS += builtin/count-objects.o > +BUILTIN_OBJS += builtin/credential-cache--daemon.o > +BUILTIN_OBJS += builtin/credential-cache.o > +BUILTIN_OBJS += builtin/credential-store.o > BUILTIN_OBJS += builtin/credential.o > BUILTIN_OBJS += builtin/describe.o > BUILTIN_OBJS += builtin/diff-files.o Wow. Both of these hunks are from me, and I clearly _tried_ to put them in the right place. I think...maybe I'm just bad at alphabetizing? Curiously, the only subtle part (ascii "-" versus ".") was wrong in the original spot I moved it from, so I won't blame myself for that. :) Anyway, the whole patch looks good to me. -Peff
