Among external function declarations, somehow only these two functions that return pointer-to-function were declared with "extern" in front. Ideally, we should standardise to _have_ explicit "extern" in front for all function (and data) decls, but let's make things uniform first. Bulk re-addition of extern can be done without any extra difficulty with or without this change. Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> --- * A patch before morning coffee, could be totally off the mark with trivial thinko. git-compat-util.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-compat-util.h b/git-compat-util.h index 7a0fb7a045..56e0e1e79d 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -491,9 +491,9 @@ static inline int const_error(void) void set_die_routine(NORETURN_PTR void (*routine)(const char *err, va_list params)); void set_error_routine(void (*routine)(const char *err, va_list params)); -extern void (*get_error_routine(void))(const char *err, va_list params); +void (*get_error_routine(void))(const char *err, va_list params); void set_warn_routine(void (*routine)(const char *warn, va_list params)); -extern void (*get_warn_routine(void))(const char *warn, va_list params); +void (*get_warn_routine(void))(const char *warn, va_list params); void set_die_is_recursing_routine(int (*routine)(void)); int starts_with(const char *str, const char *prefix);
