> From: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > > This commit provides basic utility classes for the reftable library. > > Since the reftable library must compile standalone, there may be some overlap > with git-core utility functions. > > Signed-off-by: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > --- > Makefile | 26 ++++++- > reftable/basics.c | 131 +++++++++++++++++++++++++++++++++ > reftable/basics.h | 48 +++++++++++++ > reftable/blocksource.c | 148 ++++++++++++++++++++++++++++++++++++++ > reftable/blocksource.h | 22 ++++++ > reftable/compat.c | 110 ++++++++++++++++++++++++++++ > reftable/compat.h | 48 +++++++++++++ > reftable/publicbasics.c | 100 ++++++++++++++++++++++++++ > reftable/reftable-tests.h | 22 ++++++ > reftable/strbuf.c | 142 ++++++++++++++++++++++++++++++++++++ > reftable/strbuf.h | 80 +++++++++++++++++++++ > reftable/strbuf_test.c | 37 ++++++++++ > reftable/system.h | 51 +++++++++++++ > t/helper/test-reftable.c | 8 +++ > t/helper/test-tool.c | 1 + > t/helper/test-tool.h | 1 + I think duplicating things like strbuf is an unnecessary burden if Git is to maintain this library. Something like "reftable will only import git-compat-util.h and strbuf.h, and any project that wants to use reftable must make sure that these functions and data structures are available" would be more plausible.
