On Mon, Oct 5, 2020 at 3:17 AM Jeff King <peff@xxxxxxxx> wrote: > > On Tue, Sep 22, 2020 at 07:49:24PM -0300, Matheus Tavares wrote: > > > +static int write_pc_item_to_fd(struct parallel_checkout_item *pc_item, int fd, > > + const char *path, struct checkout *state) > > The "state" parameter is unused here. Maybe this on top of > mt/parallel-checkout-part-1? > > -- >8 -- > Subject: parallel-checkout: drop unused checkout state parameter > > The write_pc_item_to_fd() function takes a "struct checkout *state" > parameter, but never uses it. This was true in its introduction in > fa33dd99f0 (unpack-trees: add basic support for parallel checkout, > 2020-09-22). Its caller, write_pc_item(), has already pulled the useful > bits from the state struct into the "path" variable. Let's drop the > useless parameter. > > Signed-off-by: Jeff King <peff@xxxxxxxx> Good catch, thanks. I was going to suggest squashing this into fa33dd99f0, but I noticed that mt/parallel-checkout-part-1 is already in next. We don't re-roll series that are already in next, right?
