This script has already expanded beyond its original intent of ".. in
submodule names" to include other malicious submodule bits. Let's update
the name and description to reflect that, as well as the fact that we'll
soon be adding similar tests for other meta-files (.gitattributes, etc).
We'll also renumber it to move it out of the group of submodule-specific
tests.
Signed-off-by: Jeff King <peff@xxxxxxxx>
---
...5-submodule-names.sh => t7450-bad-meta-files.sh} | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
rename t/{t7415-submodule-names.sh => t7450-bad-meta-files.sh} (95%)
diff --git a/t/t7415-submodule-names.sh b/t/t7450-bad-meta-files.sh
similarity index 95%
rename from t/t7415-submodule-names.sh
rename to t/t7450-bad-meta-files.sh
index 5c95247180..6b703b12bc 100755
--- a/t/t7415-submodule-names.sh
+++ b/t/t7450-bad-meta-files.sh
@@ -1,9 +1,16 @@
#!/bin/sh
-test_description='check handling of .. in submodule names
+test_description='check forbidden or malicious patterns in .git* files
-Exercise the name-checking function on a variety of names, and then give a
-real-world setup that confirms we catch this in practice.
+Such as:
+
+ - presence of .. in submodule names;
+ Exercise the name-checking function on a variety of names, and then give a
+ real-world setup that confirms we catch this in practice.
+
+ - nested submodule names
+
+ - symlinked .gitmodules, etc
'
. ./test-lib.sh
. "$TEST_DIRECTORY"/lib-pack.sh
--
2.28.0.1295.g4824feede7
