Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > On Sat, 13 Jul 2019, Carlo Arenas wrote: > >> On Sat, Jul 13, 2019 at 2:29 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> > >> > I wish if we could say >> > >> > struct patch patch = {}; >> >> that is actually a GNU extension that is supported by gcc and clang (at least) >> and that sparse also recognizes as valid; it is also valid C++ so it might be >> even supported by MSVC. > > It seems to be supported by MSVC, at least as of VS2019. In <nycvar.QRO.7.76.6.2010021555290.50@xxxxxxxxxxxxxxxxx> on Fri, 2 Oct 2020 15:57:45 +0200 (CEST), it was said: > Before you further split it up, I encourage you to include these patches > without which the CI builds will continue to fail (Junio, could I ask you > to either cherry-pick them from https://github.com/git-for-windows/git's > shears/seen branch, or apply them from the mbox?): > > -- snipsnap -- > From e485e006f34922439f2e971a1c5c38b8ca56c011 Mon Sep 17 00:00:00 2001 > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > Date: Wed, 30 Sep 2020 14:46:59 +0200 > Subject: [PATCH 1/3] fixup??? reftable: rest of library > > struct abc x = {} > > is a GNUism. Perhaps VS2020 no longer allows it? ;-) Jokes aside, I think we agreed in that old thread I am responding to that "= { 0 }" was the way to go, so let's keep doing so. Thanks.