Hi, Han-Wen Nienhuys wrote: > TODO: relicense? This line presumably doesn't want to be part of permanent history. :) Instead, it can say a little about rationale. For example, does this make the code easier for other projects like libgit2 to share? > Signed-off-by: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > --- > reftable/LICENSE | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 reftable/LICENSE Should there be a reftable/README as well? [...] > --- /dev/null > +++ b/reftable/LICENSE > @@ -0,0 +1,31 @@ > +BSD License > + > +Copyright (c) 2020, Google LLC > +All rights reserved. nit: Google seems to prefer a slightly more spartan form of this license text: https://opensource.google/docs/releasing/licenses/#bsd-license-file Nits aside, except for the TODO line, this patch looks reasonable to me. Thanks, Jonathan
