"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> +struct reftable_record reftable_new_record(uint8_t typ)
> +{
> + struct reftable_record rec = { NULL };
I can see a lot of "sparse" inspired work went into this, but we
would want to take the previous discussion into account, as nothing
has changed since then.
https://lore.kernel.org/git/41a60e60-d2c0-7d54-5456-e44d106548a4@xxxxxxxx/
https://lore.kernel.org/git/1df91aa4-dda5-64da-6ae3-5d65e50a55c5@xxxxxxxxxxxxxxxxxxxx/
Unfortunately we didn't reach a clear consensus back then; I thought
we saw a fix to make sparse silent when we use the "= { 0 }" idiom
in recent versions of sparse, but the above threads do not have any
mention of it, so either I am misremembering or there were other
discussions on the same topic where it was also mentioned.
> + switch (typ) {
Need blank before this line.
Thanks.
