On Wed, Sep 23, 2020 at 12:47 AM Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> > --- > > Hi Han-Wen Nienhuys, > > If you need to re-roll your 'hn/reftable' branch, could you please squash this > into the relevant patches. > Thanks for the heads-up. I fixed some of these issues in the source at google/reftable. I've seen a Helped-By footer used to acknowledge these types of contributions, but I'm not sure on which of the 13 commits I should put that; suggestions? > This patch is based on top of 'seen' and removes 20 sparse warnings (19 of the Could you tell me how I can run these checks myself? > Just for your information, you may want to look at the following 27 symbols: > > reftable/merged.o - reftable_merged_table_hash_id > > reftable/merged.o - reftable_merged_table_max_update_index > > reftable/merged.o - reftable_merged_table_min_update_index > > reftable/merged.o - reftable_merged_table_seek_log_at > > reftable/publicbasics.o - reftable_error_to_errno > > reftable/publicbasics.o - reftable_set_alloc > > reftable/reader.o - reftable_reader_seek_log_at > > reftable/stack.o - reftable_addition_close > > reftable/stack.o - reftable_stack_auto_compact These functions are part of the public API. We'll need to get the reftable glue code into seen. Perhaps some need unittest coverage too. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
