Thanks everyone for your comments. Patch 1 is exactly the same, and in
patch 2, I've changed the config check to use test_cmp_config with
"--get-all", as requested.
Comment noted about saying "this" without informing the reader what
it's referring to - in this case, it was about the issue in patch 2.
Jonathan Tan (2):
promisor-remote: remove unused variable
fetch: do not override partial clone filter
builtin/fetch.c | 2 +-
list-objects-filter-options.c | 10 +++++++++-
promisor-remote.c | 5 -----
promisor-remote.h | 2 +-
t/t5601-clone.sh | 3 ++-
5 files changed, 13 insertions(+), 9 deletions(-)
Range-diff against v1:
-: ---------- > 1: 625e7f148e promisor-remote: remove unused variable
1: af960f33b6 ! 2: c3ced59875 fetch: do not override partial clone filter
@@ list-objects-filter-options.c: void partial_clone_register(
## t/t5601-clone.sh ##
-@@ t/t5601-clone.sh: test_expect_success 'partial clone with -o' '
- git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
+@@ t/t5601-clone.sh: test_expect_success 'partial clone' '
+
+ test_expect_success 'partial clone with -o' '
+ partial_clone_server server &&
+- git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
++ git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client &&
++ test_cmp_config -C client "blob:limit=0" --get-all remote.blah.partialclonefilter
'
-+test_expect_success 'ensure that filter is written to config' '
-+ FILTER=$(git -C client config --get remote.blah.partialclonefilter) &&
-+ test "$FILTER" = "blob:limit=0"
-+'
-+
test_expect_success 'partial clone: warn if server does not support object filtering' '
- rm -rf server client &&
- test_create_repo server &&
--
2.28.0.709.gb0816b6eb0-goog
