Hi Danh, On Sun, 27 Sep 2020, Đoàn Trần Công Danh wrote: > On 2020-09-26 22:32:25+0200, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > > > I personally don't install my dev tools(except Visual Studio) to > > > Program Files(because of the _space_), it messes up the Makefiles. > > > > Sure, and that's your prerogative. There's unfortunately no good way to > > support your use case. > > > > Luckily, the vast majority of Git for Windows' users do not change the > > default location, and this patch is for them. (And "them" in this case > > includes me, personally ;-)) > > This doesn't fit into my view of Git for Windows' users > For some users that have the Administrator right, it's the default > location if they grant the Administrator right for the installer. > > For those poor souls that works for enterprise companies, and thoses > that not feel comfortable give Administrator right to _another_ > installer, the installer will install into (hopeful, I type it right): > > %USERPROFILE%/AppData/Local/Programs/Git Those poor souls that work for enterprise companies often have Git for Windows installed by default. And of course, that default would be in `C:\Program Files\Git`. > I think it's better to offer SH_EXE as an OPTION, let user specify it > as will. And we'll search in PATH if it's not specified, fallback to > 2 default value if not found. That's exactly as it is right now. You can specify `SH_EXE` (but only if running CMake manually, not via Visual Studio). If you don't, it searches `PATH`, and with my patch it then falls back to trying to find `sh.exe` in Git for Windows' default location. So I think we're in agreement here? Ciao, Dscho
